feat: validate space strategies #513

wa0x6e · 2025-03-09T22:37:30Z

Toward https://github.com/snapshot-labs/workflow/issues/227
Toward https://github.com/snapshot-labs/workflow/issues/631

This PR adds validation to the space top level strategies.

Summary

It will ensure that:

top level strategies are existing strategies
top level strategies are not disabled

On both cases, it will return an error, preventing:

saving space settings with inexistent or disabled strategies
creating proposals when space settings contains inexistent or disabled strategies

The only disabled strategies right now is multichain

Changes

In order to accomplish the strategies validation, we needed to have a source of truth for valid and enabled strategies. This list will come from https://score.snapshot.org/api/strategies , and there is a new file which will poll and refresh a strategies object regularly, like on the hub.
The infinite loop is started on express.js app start, and will end gracefully on shutdown.

The validateSpaceSettings function, which was located in writer/settings.ts, has been extracted into its own file, in helper/validation.ts, since this function was also used by writer/proposal.ts
It makes more sense to have this common function inside a helper, which is also simplifying the test considerably, and avoiding duplicates tests.

Finally, there's been some refactoring in the tests, to:

extract validateSpaceSettings into its own file
remove duplicates tests in settings.tests.ts and proposals.test.ts

Test

Use SDK to send space setting with inexisting strategies
It should return error
Use SDK to send space setting with multichain strategy
It should return error

If not using an SDK, you can:

update your to use multichain strategies on production
connect your sx-ui to this sequencer branch
create a proposal on your space
sequencer should return an error
update your spaces settings (keep the multichain strategy)
sequencer should return an error

src/writer/settings.ts

ChaituVR

utAck, other than above this looks good

* fix: duplicate request preventor for EIP-1271 requests * fix test

* chore: allows 50 follows for turbo users * chore: allows 50 follows for turbo users

* fix: all copeland on production * fix: remove unused variable

Updated mantle to mnt as it's new NetworkID for it.

…524) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.54 to 0.12.55. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.54...v0.12.55) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…525) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.55 to 0.12.56. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.55...v0.12.56) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…526) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.56 to 0.12.57. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.56...v0.12.57) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) * feat: sync spaces custom domain with walletconnect allowed origins * refactor: better variable name * Update .env.example Co-authored-by: Less <[email protected]> * chore: only use domain without protocol prefix --------- Co-authored-by: Chaitanya <[email protected]> Co-authored-by: Less <[email protected]>

* feat: prevent non-premium networks * add testcases * Improve network filtering and fix test case

…#528)

* feat: use correct network when fetching shib space controller * chore: use network realm instead of chain id * fix: allow network param override

…531) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.57 to 0.12.58. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.57...v0.12.58) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.12.58 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add turbo tracking every 10s * fix: correct syntax for GetSpaces query * ci: deactivate schnaps for tests * refactor: rename to turbo_expiration * chore: remove quotes around url in .env.example Co-authored-by: Chaitanya <[email protected]> * refactor: only track if SCHNAPS_API_URL is set * chore: remove log * chore: remove dead env var Co-authored-by: Wan <[email protected]> * refactor: move while loop out of if condition Co-authored-by: Wan <[email protected]> * lint: fix * chore: remove track turbo status * ci: move loop in if condition * refactor: move while loop out of if condition * fix: process only relevant spaces for the instance network * fix: use sentry to capture errors * fix: use fech with keep alive * fix: fix invalid comparison * docs: add note about future feature * fix: only update `turbo_expiration` field * fix: improve sql query --------- Co-authored-by: Chaitanya <[email protected]> Co-authored-by: Wan <[email protected]>

…532) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.58 to 0.12.59. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.58...v0.12.59) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.12.59 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…533) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.12.59 to 0.12.60. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.12.59...v0.12.60) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.12.60 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: infer turbo status from turbo expiration date * fix: update schema.sql

) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.14.1 to 0.14.2. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.14.1...v0.14.2) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.14.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.14.2 to 0.14.4. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.14.2...v0.14.4) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.14.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

- Add validation to prevent circular references in space hierarchy - Reject when space.parent equals the space ID - Reject when space.children array contains the space ID - Add comprehensive tests for parent/child validation - Ensure proper error messages for validation failures

) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.14.4 to 0.14.5. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.14.4...v0.14.5) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.14.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add support for sonic domain name * fix: fix wrong sonic network

) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.14.5 to 0.14.6. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.14.5...v0.14.6) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.14.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wan <[email protected]>

Bumps @snapshot-labs/pineapple from 1.1.0 to 1.2.0. --- updated-dependencies: - dependency-name: "@snapshot-labs/pineapple" dependency-version: 1.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wan <[email protected]>

) Bumps [@snapshot-labs/snapshot.js](https://github.com/snapshot-labs/snapshot.js) from 0.14.6 to 0.14.7. - [Release notes](https://github.com/snapshot-labs/snapshot.js/releases) - [Commits](snapshot-labs/snapshot.js@v0.14.6...v0.14.7) --- updated-dependencies: - dependency-name: "@snapshot-labs/snapshot.js" dependency-version: 0.14.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

refactor: refactor:

Copilot

Pull Request Overview

This PR adds validation for space strategies to ensure they are existing and enabled strategies. The validation prevents saving space settings or creating proposals with invalid strategies, specifically targeting the disabled "multichain" strategy.

Key changes:

Extracts strategy validation logic into a new helper module with centralized validation
Implements strategy polling from the score API to maintain a source of truth for valid strategies
Refactors tests to use mocked validation functions and removes duplicate test code

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`src/helpers/validation.ts`	New validation helper containing extracted `validateSpaceSettings` function with strategy validation
`src/helpers/strategies.ts`	New module that polls strategy data from score API and maintains strategies state
`src/index.ts`	Adds strategy refresh initialization and graceful shutdown handling
`src/writer/settings.ts`	Removes validation logic and imports from new validation helper
`src/writer/proposal.ts`	Updates to use validation helper instead of local validation
`test/unit/helpers/validation.test.ts`	New comprehensive test suite for validation logic
`test/unit/writer/settings.test.ts`	Refactored to mock validation helper and remove duplicate tests
`test/unit/writer/proposal.test.ts`	Simplified to use mocked validation helper
`test/integration/ingestor.test.ts`	Adds strategy refresh initialization for integration tests

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

test/unit/helpers/validation.test.ts

test/integration/ingestor.test.ts

wa0x6e · 2025-08-15T00:29:38Z

The PR had been refactored since last review, to fetch and cache the strategies list, like on the hub, instead of getting it on each verify() call.

Also some refactoring to extract validateSpaceSetting into a helper, for easier testing.

See the updated PR description

PR updated substantially

wa0x6e requested a review from Copilot March 9, 2025 22:37

This comment was marked as outdated.

Sign in to view

wa0x6e force-pushed the feat-validate-space-strategies branch from 0188a18 to 5d8276d Compare March 9, 2025 22:58

feat: validate space strategies

fac6311

wa0x6e force-pushed the feat-validate-space-strategies branch from 5d8276d to fac6311 Compare March 9, 2025 23:15

wa0x6e marked this pull request as ready for review March 10, 2025 17:49

wa0x6e requested a review from ChaituVR March 11, 2025 11:45

ChaituVR requested changes Mar 12, 2025

View reviewed changes

src/writer/settings.ts Outdated Show resolved Hide resolved

src/writer/settings.ts Outdated Show resolved Hide resolved

src/writer/settings.ts Outdated Show resolved Hide resolved

ChaituVR previously approved these changes Mar 14, 2025

View reviewed changes

ChaituVR and others added 21 commits August 13, 2025 02:34

fix: duplicate request preventor for EIP-1271 requests (#515)

09cde68

* fix: duplicate request preventor for EIP-1271 requests * fix test

chore: increase follow limit for Turbo users (#516)

611e081

* chore: allows 50 follows for turbo users * chore: allows 50 follows for turbo users

fix: allow copeland on production (#517)

4d8f1ad

* fix: all copeland on production * fix: remove unused variable

feat: use unified API to check if SX space exists (#520)

ae2a23f

feat: add mnt, ape, curtis to networks whitelist (#521)

badd12a

Updated mantle to mnt as it's new NetworkID for it.

fix: prevent non-premium networks (#522)

a1dee26

* feat: prevent non-premium networks * add testcases * Improve network filtering and fix test case

fix: allow turbo spaces to create proposals with non-premuim networks (…

a21aaca

…#528)

feat: use correct network when fetching shib space controller (#527)

da6af19

* feat: use correct network when fetching shib space controller * chore: use network realm instead of chain id * fix: allow network param override

chore: use pineapple gateway to get JSON on poke (#535)

61578e2

fix: skip indexing from outdated schnaps api (#537)

dcde46a

fix: assign fallback value (#538)

5adf223

fix: infer turbo status from turbo expiration date (#539)

815b897

* fix: infer turbo status from turbo expiration date * fix: update schema.sql

chore: mark eden-online-override strategy as overriding

fa1b786

dependabot bot and others added 16 commits August 13, 2025 02:37

fix: update network column to support starknet chain id (#558)

181ca38

feat: add support for sonic domain name (#562)

c36e9d8

* feat: add support for sonic domain name * fix: fix wrong sonic network

chore: add sonic-staked-balance to override strategy (#568)

271152c

chore: remove matic from sx (#573)

89b2188

feat: validate space strategies

6195859

chore: lint fix

7eee9a6

feat: validate space strategies

ff9cae4

chore: lint fix

b17284f

Merge branch 'master' into feat-validate-space-strategies

ec91679

wa0x6e force-pushed the feat-validate-space-strategies branch from f688b47 to b0e08e3 Compare August 14, 2025 23:00

wa0x6e added 2 commits August 15, 2025 03:19

refactor: better strategies handling

49162ef

refactor: refactor:

fix: stop infinite loop on app shutdown

18c9919

wa0x6e force-pushed the feat-validate-space-strategies branch from b0e08e3 to 18c9919 Compare August 14, 2025 23:19

wa0x6e added 2 commits August 15, 2025 03:21

refactor: remove magic number

2eb90a5

fix: update error message to reflect disabled status

e12e40c

wa0x6e requested a review from Copilot August 14, 2025 23:44

Copilot AI reviewed Aug 14, 2025

View reviewed changes

test/unit/helpers/validation.test.ts Show resolved Hide resolved

test/unit/helpers/validation.test.ts Show resolved Hide resolved

test/unit/helpers/validation.test.ts Show resolved Hide resolved

test/integration/ingestor.test.ts Show resolved Hide resolved

wa0x6e added 2 commits August 15, 2025 04:08

refactor: remove useless try/catch

a8b3668

test: reset mock after each test

c214894

wa0x6e requested a review from ChaituVR August 15, 2025 00:27

feat: only allow override strategies on pro spaces (#581)

6c57cdf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: validate space strategies #513

feat: validate space strategies #513

wa0x6e commented Mar 9, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChaituVR left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wa0x6e commented Aug 15, 2025

Uh oh!

Uh oh!

feat: validate space strategies #513

Are you sure you want to change the base?

feat: validate space strategies #513

Conversation

wa0x6e commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChaituVR left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wa0x6e commented Aug 15, 2025

Uh oh!

Uh oh!

wa0x6e commented Mar 9, 2025 •

edited

Loading